CheckNodePIDPressure is not supported in v1.10 #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I confirm, without |
woopstar
approved these changes
Jun 29, 2018
|
ci check this |
drekle
reviewed
Jun 29, 2018
| @@ -10,7 +10,6 @@ | |||
| {"name" : "GeneralPredicates"}, | |||
| {"name" : "CheckNodeMemoryPressure"}, | |||
| {"name" : "CheckNodeDiskPressure"}, | |||
| {"name" : "CheckNodePIDPressure"}, | |||
There was a problem hiding this comment.
@Miouge1 Maybe you should just add a conditional around kube_version var for all the ones added. However I was just going to remove it as well. :)
There was a problem hiding this comment.
I think this is v1.12.0-alpha.0
something like...
{% if kube_version | version_compare('v1.11', '>') %}
... however not sure on this.
probably a lot of these predicates need version checks.
drekle
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2737 accidentally introduces
CheckNodePIDPressurewhich is was released withv1.11(see CHANGELOG-1.11.md, PR #60007). Since Kubespray currently supports v1.10 this PR removesCheckNodePIDPressure.Issue reported by @avoidik on slack