Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cannot stop & remove all cri containers via remove_node.yml #11631

Conversation

tico88612
Copy link
Member

@tico88612 tico88612 commented Oct 13, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

If you use remove_node.yml, deleting the node does not stop the container, and the container will continue to exist on the host.

Which issue(s) this PR fixes:

Fixes #11627

Special notes for your reviewer:

I have compared the remove_node.yml and reset.yml diffs, and before adding these changes, ansible_facts.services["containerd.service"] would fail to check for triggering the container stop and delete behaviors.

Does this PR introduce a user-facing change?:

Fix: cannot stop & remove all cri containers via remove_node.yml

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2024
@tico88612
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 13, 2024
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@VannTen
Copy link
Contributor

VannTen commented Oct 15, 2024 via email

Before adding these changes, `ansible_facts.services["containerd.service"]` will not defined and fail to check for triggering the container stop and delete behaviors.

Signed-off-by: ChengHao Yang <[email protected]>
@tico88612 tico88612 force-pushed the fix/remove-node-not-stop-container branch from c429d43 to a273f04 Compare October 15, 2024 07:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@VannTen
Copy link
Contributor

VannTen commented Oct 15, 2024 via email

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2024
@tico88612
Copy link
Member Author

/cherry-pick release-2.26
/cherry-pick release-2.25

@k8s-infra-cherrypick-robot

@tico88612: once the present PR merges, I will cherry-pick it on top of release-2.26 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.26
/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 687fa3d into kubernetes-sigs:master Oct 15, 2024
40 checks passed
@tico88612 tico88612 deleted the fix/remove-node-not-stop-container branch October 15, 2024 07:50
@k8s-infra-cherrypick-robot

@tico88612: new pull request created: #11637

In response to this:

/cherry-pick release-2.26
/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@tico88612: new pull request created: #11638

In response to this:

/cherry-pick release-2.26
/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The remove-node.yml playbook doesn’t clean up static pods and DaemonSet pods
5 participants