-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: cannot stop & remove all cri containers via remove_node.yml #11631
Fix: cannot stop & remove all cri containers via remove_node.yml #11631
Conversation
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
Could you put that in the commit message ? That way it's shorter to get the rationale when doing `git blame`
|
Before adding these changes, `ansible_facts.services["containerd.service"]` will not defined and fail to check for triggering the container stop and delete behaviors. Signed-off-by: ChengHao Yang <[email protected]>
c429d43
to
a273f04
Compare
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, tico88612, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-2.26 |
@tico88612: once the present PR merges, I will cherry-pick it on top of release-2.26 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@tico88612: new pull request created: #11637 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@tico88612: new pull request created: #11638 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If you use remove_node.yml, deleting the node does not stop the container, and the container will continue to exist on the host.
Which issue(s) this PR fixes:
Fixes #11627
Special notes for your reviewer:
I have compared the
remove_node.yml
andreset.yml
diffs, and before adding these changes,ansible_facts.services["containerd.service"]
would fail to check for triggering the container stop and delete behaviors.Does this PR introduce a user-facing change?: