Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CentOS-Base.repo exists for CentOS 7 #11402

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Check CentOS-Base.repo exists for CentOS 7 #11402

merged 1 commit into from
Jul 30, 2024

Conversation

tu1h
Copy link
Member

@tu1h tu1h commented Jul 29, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
It's should check the existence of the CentOS-Base.repo before we make changes with it. Because we cannot assume the system is clean enough, and the files in /etc/yum.repos.d may be changed already.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Check CentOS-Base.repo exists for CentOS 7

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2024
@tu1h
Copy link
Member Author

tu1h commented Jul 29, 2024

@tico88612 PTAL:-)

@tu1h
Copy link
Member Author

tu1h commented Jul 29, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 29, 2024
@yankay
Copy link
Member

yankay commented Jul 29, 2024

Thanks @tu1h
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tu1h, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
kundan2707
kundan2707 reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@tu1h
Copy link
Member Author

tu1h commented Jul 30, 2024

/retest

@yankay yankay merged commit 86f9803 into kubernetes-sigs:master Jul 30, 2024
38 of 39 checks passed
@yankay
Copy link
Member

yankay commented Jul 30, 2024

HI @tu1h
Please add the release note :-)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 30, 2024
@tico88612
Copy link
Member

/cherry-pick release-2.25

@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11438

In response to this:

/cherry-pick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 10, 2024
Merged
@yankay yankay mentioned this pull request Aug 28, 2024
Closed
@tico88612
Copy link
Member

/cherry-pick release-2.24

@k8s-infra-cherrypick-robot
Copy link

@tico88612: new pull request created: #11546

In response to this:

/cherry-pick release-2.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kundan2707 kundan2707 kundan2707 left review comments

@cyclinder cyclinder Awaiting requested review from cyclinder

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

Assignees

@kundan2707 kundan2707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tu1h @yankay @k8s-ci-robot @tico88612 @k8s-infra-cherrypick-robot @kundan2707