Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openstack cleanup by changing the delete security_group order #11299

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix openstack cleanup by changing the delete security_group order #11299

merged 1 commit into from
Jun 21, 2024

Conversation

yankay
Copy link
Member

@yankay yankay commented Jun 17, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Fix openstack cleanup by changing the delete security_group order

Which issue(s) this PR fixes:

Fixes #11263

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix openstack cleanup by change the delete  security_group order

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2024
@yankay yankay changed the title [WIP] Fix openstack cleanup by changing the delete security_group order Fix openstack cleanup by changing the delete security_group order Jun 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2024
@yankay
Copy link
Member Author

yankay commented Jun 18, 2024 •
edited
Loading

HI @MrFreezeex @mzaian

Would you please help to review it :-)

@yankay
fix openstack cleanup
b70050d 
Signed-off-by: Kay Yan <[email protected]>
@ant31
Copy link
Contributor

ant31 commented Jun 21, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2024
ant31
ant31 reviewed Jun 21, 2024
View reviewed changes
.gitlab-ci.yml
@@ -71,7 +71,7 @@ ci-not-authorized:
after_script: []
rules:
# LGTM or ok-to-test labels
- if: $PR_LABELS =~ /.*,(lgtm|ok-to-test).*|^(lgtm|ok-to-test).*/i
- if: $PR_LABELS =~ /.*,(lgtm|approved|ok-to-test).*|^(lgtm|approved|ok-to-test).*/i
Copy link
Contributor

@ant31 ant31 Jun 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no sure about this change (not against either)
approvers can also add the /ok-to-test flag themself.
idea is to no automatically trigger pipeline for PR that are not ready to be tested (including for reviewer/approvers)

@k8s-ci-robot k8s-ci-robot merged commit 647092b into kubernetes-sigs:master Jun 21, 2024
79 checks passed
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
@yankay @Rickkwa
fix openstack cleanup (kubernetes-sigs#11299)
cb816d4 
Signed-off-by: Kay Yan <[email protected]>
@yankay
Copy link
Member Author

yankay commented Aug 1, 2024

/cherrypick release-2.25

@k8s-infra-cherrypick-robot
Copy link

@yankay: new pull request created: #11410

In response to this:

/cherrypick release-2.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 1, 2024
Merged
@yankay yankay mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant31 ant31 ant31 left review comments

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@VannTen VannTen Awaiting requested review from VannTen

Assignees

@ant31 ant31

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tf-elastx_cleanup is failing with 'resource in use'
4 participants
@yankay @k8s-ci-robot @ant31 @k8s-infra-cherrypick-robot