-
Notifications
You must be signed in to change notification settings - Fork 530
Update controller-runtime to v0.8.3 #1415
Update controller-runtime to v0.8.3 #1415
Conversation
/retest |
@phantomnat: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit. |
@yuswift I re-triggered the build 🔨 ... |
Okay, it seems it doesn't work anymore due to the docker pull limits. |
Please, rebase to get the latest changes. |
0f6e31e
to
8171dac
Compare
Sorry @phantomnat - could you rebase again? |
8171dac
to
3d24a40
Compare
Ok, no problem. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimmidyson, phantomnat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3d24a40
to
63fb6ca
Compare
/lgtm |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1358
Special notes for your reviewer:
Change
runtime.Object
toruntimclient.Object