Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Update controller-runtime to v0.8.3 #1415

Conversation

phantomnat
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1358

Special notes for your reviewer:
Change runtime.Object to runtimclient.Object

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 28, 2021
@phantomnat phantomnat changed the title Update controller-runtime v0.8.3 Update controller-runtime to v0.8.3 May 28, 2021
@phantomnat
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@phantomnat: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@swiftslee
Copy link
Contributor

docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.
need help from @hectorj2f

@hectorj2f
Copy link
Contributor

@yuswift I re-triggered the build 🔨 ...

@hectorj2f
Copy link
Contributor

Okay, it seems it doesn't work anymore due to the docker pull limits.

go.mod Outdated Show resolved Hide resolved
@hectorj2f
Copy link
Contributor

Please, rebase to get the latest changes.

@phantomnat phantomnat force-pushed the update/controller-runtime-all branch from 0f6e31e to 8171dac Compare June 9, 2021 02:57
@jimmidyson
Copy link
Contributor

Sorry @phantomnat - could you rebase again?

@phantomnat phantomnat force-pushed the update/controller-runtime-all branch from 8171dac to 3d24a40 Compare June 9, 2021 12:21
@phantomnat
Copy link
Contributor Author

Ok, no problem.

@jimmidyson
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmidyson, phantomnat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2021
@phantomnat phantomnat force-pushed the update/controller-runtime-all branch from 3d24a40 to 63fb6ca Compare June 10, 2021 09:35
@hectorj2f
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 129c86f into kubernetes-retired:master Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade controller-runtime to 0.8.1
6 participants