This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
enable workqueue metrics for all controllers #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruce Ma <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hectorj2f, mars1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
This still doesnt expose worker queue. They are using a noop provider and not prometheus. |
|
I figured this out. There is some ordering issue going on where the do-once here https://github.com/kubernetes/client-go/blob/master/util/workqueue/metrics.go#L217-L227 is preventing the worker queues from showing up. I dont know how you fix this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bruce Ma [email protected]
What this PR does / why we need it:
This PR will help to enable workqueue metrics for all controllers.
Client-go has implemented a built-in metrics, but it will be disabled when created workqueue is nameless https://github.com/kubernetes/client-go/blob/fa8f4cc307b81b125f6beb2cea6f093ed9e3c069/util/workqueue/metrics.go#L231 .
So this pr is trying to assign a unique name for each controller(workqueue), and this name is usually the lowercase singular kind which is being reconciled by this controller.
Special notes for your reviewer:
NONE