Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feature: remove CrossClusterDiscovery alpha feature #1351

Conversation

hectorj2f
Copy link
Contributor

What this PR does / why we need it:

This PR removes one of the alpha features CrossClusterDiscovery. This feature should not be part of kubefed core as mentioned in #1283. The main intention is to remove from kubefed those features that are not part of its core functionalities, and consequently mark kubefed as beta.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
#1283
Special notes for your reviewer:

@hectorj2f hectorj2f self-assigned this Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorj2f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@hectorj2f hectorj2f force-pushed the hectorj2f/remove_crossclusterdisco_feat branch from 4828846 to f47d0f3 Compare January 28, 2021 10:01
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2021
@jimmidyson
Copy link
Contributor

LGTM - let's get another review from community though to validate. @irfanurrehman @RainbowMango (and anyone else interested!)

@RainbowMango
Copy link
Contributor

LGTM from me. Thanks.

Give a chance to @irfanurrehman :)

@irfanurrehman
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 07c9e28 into kubernetes-retired:master Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants