Helmv3 migration of the chart

[eumel8]

What this PR does / why we need it:

Helmv3 is out for a while. Time to migrate the chart to v3. Adjust syntax/docs, move CRDs to specific folders without templating.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1234

Special notes for your reviewer:

[k8s-ci-robot]

Welcome @eumel8!

It looks like this is your first PR to kubernetes-sigs/kubefed 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubefed has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[alejandroEsc]

Awesome first pass, thank you so much for doing this. Could you please place the output of an install using your chart?

Have the maintainers considered deprecating and adding a deprecation warning etc.. on the previous chart? Creating a new version of the chart for v3? Just wondering what is the phasing out plan exactly or are we taking a hardline approach? Other repos seem to consider having a transition period between helm versions, ala velero for example.

Finally the tests seem to timed out?

[eumel8]

@jimmidyson I know ;) There is nothing worth to skip squash messages. Summary highlights would be:

• Helm v3 introduction of KubeFed chart
• Migration guide Helm v2 to Helm v3
• CI/CD adaption for KubeFed

I'v just realized today there is a KubeFed Operator on start. I wouldn't have made a Helm v3 migration if I had known it before ;)

[jimmidyson]

@eumel8 Ooo a kubefed operator? I've not seen that - can you share any links please?

[eumel8]

@jimmidyson sure: https://github.com/openshift/kubefed-operator
But it's only Level 1 and I'm not sure if it's still in active developement.

[jimmidyson]

@eumel8 AFAIK openshift isn't planning on using kubefed any more so I guess that's not maintained (and looking at commit log that looks right).

[alejandroEsc]

eta on this?

[jimmidyson]

The commit history makes it harder to review because the diffs include stuff that is already merged to master. I'm reviewing locally now.

[jimmidyson]

I've tested this out locally and all works great - thank you!

Just a final couple of tidy up things and we're good to merge.

[jimmidyson]

@eumel8 I'm going to push a commit for the suggestion in #1260 (comment) - hope you don't mind. Then we can merge when green.

[jimmidyson]

/approve
/lgtm

[jimmidyson]

Thank you @eumel8!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eumel8, jimmidyson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jimmidyson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jimmidyson]

Also thank you to @alejandroEsc and @wangkai1994 for your review approvals - really helpful to have other sets of eyes on PRs.

[jimmidyson]

OK I messed up squashing this PR on merge 😢. Sorry again...

[RainbowMango]

Wow!

[ghost]

Thanks @eumel8