Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: enable command for crd resources #1207

Conversation

hectorj2f
Copy link
Contributor

@hectorj2f hectorj2f commented Mar 29, 2020

What this PR does / why we need it:

kubefedctl enable crd command was throwing a panic as reported in #1206. It is related to what @marun did here #470. I might need a bit more of context to address the TODO comment.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
#1206
Special notes for your reviewer:

kubefedctl enable crd
customresourcedefinition.apiextensions.k8s.io/federatedcustomresourcedefinitions.types.kubefed.io created
federatedtypeconfig.core.kubefed.io/customresourcedefinitions.apiextensions.k8s.io updated in namespace kommander

I also tested to enable one of our custom resource definitions:

$ kubefedctl federate crd addons.kubeaddons.mesosphere.io

$ kubectl get federatedcustomresourcedefinitions 
NAME                              AGE
addons.kubeaddons.mesosphere.io   51s

@hectorj2f hectorj2f added the kind/bug Categorizes issue or PR as related to a bug. label Mar 29, 2020
@hectorj2f hectorj2f self-assigned this Mar 29, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2020
@hectorj2f
Copy link
Contributor Author

/assign @jimmidyson

@hectorj2f
Copy link
Contributor Author

/assign @pmorie

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2020
@irfanurrehman
Copy link
Contributor

This change seems good to me for now.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2020
@pmorie
Copy link
Contributor

pmorie commented Apr 8, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hectorj2f, pmorie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3485e93 into kubernetes-retired:master Apr 8, 2020
@hectorj2f hectorj2f deleted the hectorj2f/fix_enable_cmd_for_crds branch April 8, 2020 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants