This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Remove generation of the template validation schema #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shashidharatd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
marun
reviewed
Jul 10, 2019
shashidharatd
force-pushed
the
remove-api-validation
branch
from
1ee06d6
to
20416ef
Compare
|
@shashidharatd This LGTM. Please update the changelog so that the change can be more easily reflected in the notes of the next release. |
|
@marun, Done. PTAL. |
|
Thank you! /lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the step to handle federation api upgrade scenario. The openapi schema validation for templates in federated API is removed.
#Ref: https://docs.google.com/document/d/1uAOMzDgczEYwKcBCuSLpdhuQPHHvRYG-w3ke9659qY0/edit#
/cc @marun