update kustomize scaffolding to work with kustomize 2.0

[Liujingfang1]

Fix #595

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Liujingfang1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[droot]

@Liujingfang1 Will this new structure work with kustomize 1.0.0 as well ?

I am thinking of cases where users have projects with current/new kustomization structure, but they have older kustomize (1.0.0) will it work for both ? because upgrading to kustomize 2.0.0 will force them to migrate to newer structure.

Also, was wondering if we can update the issue with set of kustomize commands to run to migrate the old structure to work with new structure.

[Liujingfang1]

@droot Yes, this structure works with kustomize 1.0 as well.

[Liujingfang1]

kustomize commands to run to migrate the old structure to work with new structure

There is no commands in Kustomize to migrate the structures. It requires manual work :(

[Liujingfang1]

@droot I added some instructions for migrating from the old structure to the new structure in the issue.

[droot]

Looking good. one small thing to confirm, have left a comment.

[droot]

I have to double check, but rbac manifests get generated everytime make runs, so not sure if delete all yamls in rbac directory.

[mengqiy]

IIRC it doesn't delete everything, it overwrites the content in ../rbac/rbac_role.yaml. We'd better confirm it.

[droot]

I confirmed, it doesn't delete, so the change is good.

[droot]

@Liujingfang1 The change is good, but we do not have an e2e test in travis which can verify this. we generally test kustomize related changes manually. Will you be able to perform a manual test before the merge ?

[Liujingfang1]

@droot Sure, I'll test it manually :)

[Liujingfang1]

I ran following commands and all of them succeeded. @droot

kubebuilder init --domain jingfang
kubebuilder create api --group my --version v1 --kind MyKind --resource=true --controller=true
make install
make run
kubectl apply -f config/samples/.

# deploy the manager to cluster
make docker-build IMG=jiliu/kb
make docker-push IMG=jiliu/kb
make deploy

[droot]

Awesome. Thanks for the e2e test.