✨ (go/v4): cleanup: in e2e/test.go, make Gomega assertions more concise

[mogsie]

Some of the calls to Gomega's assertions are unneccessarily long; declaring variables, and checking both errors and values. All of this can be done by Gomega itself. This is part of #4135

Expect(func()).To(ContainSubstring("X")) will

• check that any err returned from the function is nil
• check that the first return value matches "X"

Expect(func()).Error().To(HaveOccurred()) will

• check that any err returned from the function is non-nil
• check that the first return value is nil or zero.

[k8s-ci-robot]

Hi @mogsie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

/lgtm
/approved
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mogsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment