Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat : add kustomize file for crd sample #3084

Merged

Conversation

Kavinjsir
Copy link
Contributor

Description

Scaffold config/samples/kustomization.yaml which helps deploying sample CRs at ease.

Motivation

Resolve #1573

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2022
@Kavinjsir Kavinjsir force-pushed the feat/kustomize-sample branch from 765c897 to 9896d8d Compare November 18, 2022 05:06
@@ -18,6 +18,7 @@ package scaffolds

Copy link
Member

@camilamacedo86 camilamacedo86 Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kavinjsir great work, just a few nits:

a) We cannot use 🌱 on this one because this change affects the end-user so that need to be sparkles
b) We need also add this to the migration guide from v3 to v4

However, all is great. Just address this both needs it has my lgtm

c/c @everettraven @varshaprasad96 this one helps SDK because their has a plugin manifests that will create this file so that is possible build the bundle with the owned CRDs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @camilamacedo86 thx for reminding the documentation. Just added some in the place you suggested.

@Kavinjsir Kavinjsir changed the title 🌱 : add kustomize file for crd sample ✨ feat : add kustomize file for crd sample Nov 18, 2022
@Kavinjsir Kavinjsir force-pushed the feat/kustomize-sample branch from 9896d8d to dfe45e3 Compare November 18, 2022 23:30
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems great for me. 🥇
Just more a nit Could we change the title for(kustomize/v2-alpha): add kustomize file to track crd sample info

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2022
@Kavinjsir Kavinjsir force-pushed the feat/kustomize-sample branch from dfe45e3 to 2cf1e0f Compare November 21, 2022 15:57
@Kavinjsir
Copy link
Contributor Author

That seems great for me. 🥇 Just more a nit Could we change the title for(kustomize/v2-alpha): add kustomize file to track crd sample info

Yeah, sounds good! Just updated

@Kavinjsir Kavinjsir force-pushed the feat/kustomize-sample branch 2 times, most recently from e30a64c to 1090411 Compare November 22, 2022 19:10
@Kavinjsir Kavinjsir force-pushed the feat/kustomize-sample branch from 1090411 to 407b9fe Compare November 22, 2022 21:09
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great work @Kavinjsir!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kustomize support for config/samples
4 participants