-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat : add kustomize file for crd sample #3084
✨ feat : add kustomize file for crd sample #3084
Conversation
765c897
to
9896d8d
Compare
@@ -18,6 +18,7 @@ package scaffolds | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kavinjsir great work, just a few nits:
a) We cannot use 🌱 on this one because this change affects the end-user so that need to be sparkles
b) We need also add this to the migration guide from v3 to v4
- Into Common changes to allow people knows the diff: https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/migration/v3vsv4.md#common-changes
- Into the steps to migrate to allow those that will try to migrate manually knows that they need to create this file and add all kinds there: https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md
However, all is great. Just address this both needs it has my lgtm
c/c @everettraven @varshaprasad96 this one helps SDK because their has a plugin manifests that will create this file so that is possible build the bundle with the owned CRDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @camilamacedo86 thx for reminding the documentation. Just added some in the place you suggested.
9896d8d
to
dfe45e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems great for me. 🥇
Just more a nit Could we change the title for(kustomize/v2-alpha): add kustomize file to track crd sample info
dfe45e3
to
2cf1e0f
Compare
Yeah, sounds good! Just updated |
e30a64c
to
1090411
Compare
1090411
to
407b9fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Great work @Kavinjsir!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Scaffold
config/samples/kustomization.yaml
which helps deploying sample CRs at ease.Motivation
Resolve #1573