✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha #3032

camilamacedo86 · 2022-10-22T09:20:27Z

Description

Address the main changes tracked to be applied in the new scaffold in order to clean up by removing the options that are no longer supported and the usage of k8s apis which does not work with k8s 1.22+ and 1.25+
Add migration guide and initial docs to allow users to migrate from go/v2 to the go/v4-alpha if they wish since we plan to remove the go/v2 when we bump k8s 1.26 (we can improve the docs in follow-ups by providing further manual steps for example)
Allow us looking for to perform any required change in the go/v4-alpha golang base scaffold files as well before making it stable.

Motivation

Closes: For go/v4, remove the option to create v1beta1 CRD and Webhooks #2531
Closes: API "k8s.io/api/admission/v1beta1"` is no longer served since 1.25 and cannot be used #3030
Cleanup and remove the option to downgrade the versions to try to support v1beta1 versions since it does not make sense for go/v4. No longer provide backwards compatible support with k8s versions < 1.16

camilamacedo86 · 2022-10-24T07:16:12Z

/hold cancel

Kavinjsir

Thx @camilamacedo86 !
Added some nits.
I will go for some practices following the docs to finish my review.

docs/book/src/migration/legacy.md

docs/book/src/migration/v3vsv4.md

Kavinjsir · 2022-10-25T14:53:13Z

docs/book/src/migration/v3vsv4.md

+
+## Common changes
+
+- `go/v4-alpha` projects use Kustomize v4x (instead of v3x)


Nits:

use Kustomize v4.x.x (instead of v3.x.x)

In this case is 4x because we can bump the version.
The breaking changes are only faced in the major bump from 3x to 4x

That makes sense. 👍🏼

docs/book/src/migration/migration_guide_gov3_to_gov4.md

camilamacedo86 · 2022-10-25T16:29:54Z

Hi @Kavinjsir,

Thank you for the help. Mainly all suggestions are applied.

Kavinjsir

lgtm!

Kavinjsir · 2022-11-02T04:11:48Z

docs/book/src/migration/v3vsv4.md

+- no longer provide backwards compatible support with k8s versions < `1.16`
+
+<aside class="note">
+<H1> TL;DR of the New `go/v4-alpha` Plugin </H1>


See that below contains another tldr header with contents. Do we need this h1 block?

All notes have that. It creates a title @Kavinjsir

Kavinjsir · 2022-11-02T04:37:52Z

pkg/plugins/golang/v4/api.go

+	p.resource = res
+
+	// TODO: re-evaluate whether y/n input still makes sense. We should probably always
+	//       scaffold the resource and controller.


Agree to directly generate resources and controller code with asking users.
Assuming these are the common patterns to implement CRD operators.

Hun, we need to remove this TODO.
It cames from the go v3 code as well.
We need to have the Y/N option. WHY?

We can reconcile a Kind that is not owned by the project.
That can be a core type (i.e Deployments) or an external/third-party one like a CRD created by other projects. See: #3082

Lets remove it in a follow up.

Sounds good. Makes sense to leave options for users considering on such wider use cases.

varshaprasad96

Nits on doc. Else looks good to me! 👍

docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

docs/book/src/migration/multi-group.md

docs/book/src/migration/v3vsv4.md

docs/book/src/plugins/to-be-extended.md

camilamacedo86 · 2022-11-17T19:31:06Z

Thank you for the review @varshaprasad96
All addressed!

Co-authored-by: Varsha <[email protected]>

camilamacedo86 · 2022-11-17T19:59:03Z

@varshaprasad96 @everettraven @Kavinjsir could you help us move with this one?

Kavinjsir

Looks good to me!

Kavinjsir · 2022-11-17T20:35:30Z

pkg/plugins/golang/v4/api.go

+	p.resource = res
+
+	// TODO: re-evaluate whether y/n input still makes sense. We should probably always
+	//       scaffold the resource and controller.


Sounds good. Makes sense to leave options for users considering on such wider use cases.

varshaprasad96

Just a few more nits in doc. After they are addressed its /lgtm from my end.

docs/book/src/plugins/go-v4-plugin.md

docs/book/src/migration/legacy.md

docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

k8s-ci-robot · 2022-11-17T23:51:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [camilamacedo86,varshaprasad96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Co-authored-by: Varsha <[email protected]>

camilamacedo86 · 2022-11-18T07:23:20Z

Moving forward with this one since we got enough reviews!
Thank you @varshaprasad96 and @Kavinjsir

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2022

camilamacedo86 requested a review from everettraven October 22, 2022 09:20

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 22, 2022

camilamacedo86 requested review from Kavinjsir and everettraven and removed request for everettraven October 22, 2022 09:20

k8s-ci-robot requested a review from joelanford October 22, 2022 09:20

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2022

camilamacedo86 requested review from jmrodri and varshaprasad96 October 22, 2022 09:20

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2022

camilamacedo86 force-pushed the go-v4-base branch from d8b123f to 59037cb Compare October 22, 2022 09:41

camilamacedo86 changed the title ~~✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha~~ WIP ✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha Oct 23, 2022

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2022

camilamacedo86 changed the title ~~WIP ✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha~~ ✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha Oct 23, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2022

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 24, 2022

Kavinjsir reviewed Oct 25, 2022

View reviewed changes

camilamacedo86 force-pushed the go-v4-base branch from 59037cb to 57943a0 Compare October 25, 2022 16:29

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2022

camilamacedo86 requested a review from Kavinjsir October 25, 2022 16:30

Kavinjsir approved these changes Nov 2, 2022

View reviewed changes

Kavinjsir reviewed Nov 2, 2022

View reviewed changes

varshaprasad96 reviewed Nov 2, 2022

View reviewed changes

camilamacedo86 force-pushed the go-v4-base branch from 40951dc to 2e7ddf5 Compare November 17, 2022 19:30

camilamacedo86 requested a review from varshaprasad96 November 17, 2022 19:30

✨ Add go/v4 base and migration guide

8fcc643

Co-authored-by: Varsha <[email protected]>

camilamacedo86 force-pushed the go-v4-base branch from 5202445 to 8fcc643 Compare November 17, 2022 19:44

Kavinjsir approved these changes Nov 17, 2022

View reviewed changes

varshaprasad96 approved these changes Nov 17, 2022

View reviewed changes

camilamacedo86 and others added 5 commits November 18, 2022 06:59

Update docs/book/src/plugins/go-v4-plugin.md

920b923

Co-authored-by: Varsha <[email protected]>

Update docs/book/src/migration/legacy.md

89026b7

Co-authored-by: Varsha <[email protected]>

Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

aa90d6b

Co-authored-by: Varsha <[email protected]>

Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

9cc0c3f

Co-authored-by: Varsha <[email protected]>

Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md

00dfad7

Co-authored-by: Varsha <[email protected]>

camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022

k8s-ci-robot merged commit 1f099ea into kubernetes-sigs:master Nov 18, 2022

camilamacedo86 deleted the go-v4-base branch November 18, 2022 10:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha #3032

✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha #3032

camilamacedo86 commented Oct 22, 2022 •

edited

Loading

camilamacedo86 commented Oct 24, 2022

Kavinjsir left a comment

Kavinjsir Oct 25, 2022

camilamacedo86 Oct 25, 2022

Kavinjsir Nov 2, 2022

camilamacedo86 commented Oct 25, 2022 •

edited

Loading

Kavinjsir left a comment

Kavinjsir Nov 2, 2022

camilamacedo86 Nov 17, 2022

Kavinjsir Nov 2, 2022

camilamacedo86 Nov 17, 2022

Kavinjsir Nov 17, 2022

varshaprasad96 left a comment

camilamacedo86 commented Nov 17, 2022 •

edited

Loading

camilamacedo86 commented Nov 17, 2022

Kavinjsir left a comment

Kavinjsir Nov 17, 2022

varshaprasad96 left a comment

k8s-ci-robot commented Nov 17, 2022

camilamacedo86 commented Nov 18, 2022


		## Common changes

		- `go/v4-alpha` projects use Kustomize v4x (instead of v3x)

✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha #3032

✨ Add go/v4-alpha base and migration guide from go/v3 to go/v4-alpha #3032

Conversation

camilamacedo86 commented Oct 22, 2022 • edited Loading

Description

Motivation

camilamacedo86 commented Oct 24, 2022

Kavinjsir left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

camilamacedo86 commented Oct 25, 2022 • edited Loading

Kavinjsir left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

varshaprasad96 left a comment

Choose a reason for hiding this comment

camilamacedo86 commented Nov 17, 2022 • edited Loading

camilamacedo86 commented Nov 17, 2022

Kavinjsir left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

varshaprasad96 left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 17, 2022

camilamacedo86 commented Nov 18, 2022

camilamacedo86 commented Oct 22, 2022 •

edited

Loading

camilamacedo86 commented Oct 25, 2022 •

edited

Loading

camilamacedo86 commented Nov 17, 2022 •

edited

Loading