-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(config-gen) Updated the image gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.11.0 #2595
✨(config-gen) Updated the image gcr.io/kubebuilder/kube-rbac-proxy from v0.5.0 to v0.11.0 #2595
Conversation
448d95a
to
684baec
Compare
@@ -353,7 +353,7 @@ webhooks: | |||
--- | |||
# The following manifests contain a self-signed issuer CR and a certificate CR. | |||
# More document can be found at https://docs.cert-manager.io | |||
# WARNING: Targets CertManager 0.11 check https://docs.cert-manager.io/en/latest/tasks/upgrading/index.html for | |||
# WARNING: Targets CertManager 0.11 check https://docs.cert-manager.io/en/latest/tasks/upgrading/index.html for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the space here broke the tests.
See that it is a mock test result so that we can compare what is the result with it (what is expected)
You can check that by looking in the logs: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kubebuilder/2595/pull-kubebuilder-test/1510670366261907456#1:build-log.txt%3A77-84
c/c @NikhilSharmaWe
Revert this one for we are able to move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that in the logs but did not realize that it was important for them to be exactly same, I thought the error was because of something else.
Thanks for pointing out and explaining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contributon
But we need to ensure that it pass in the CI
See: https://github.com/kubernetes-sigs/kubebuilder/pull/2595/files#r841483786
…m v0.5.0 to v0.11.0
684baec
to
efb2334
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approved
Great work 🥇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, NikhilSharmaWe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fixes #2592