-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha #2552
Conversation
fb7c9f3
to
860a5de
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cf14483
to
d1f3058
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
d1f3058
to
02ec07e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
2a06d1f
to
c9c52ef
Compare
This comment was marked as resolved.
This comment was marked as resolved.
docs/book/src/reference/watching-resources/testdata/external-indexed-field/api.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
e130ffc
to
c469a16
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
docs/book/src/reference/watching-resources/testdata/owned-resource/controller.go
Outdated
Show resolved
Hide resolved
6fb7b17
to
2ff0972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution 🥇
IHMO we need to move forward here and add the go/v4-alpha to make it easier for users to begin to experiment kustomize v4 with and we begin to support Apple Silicon.
Also, it seems time to deprecate go/v2 since we no longer can update it (it was created only to ensure the backwards compatibility)
/hold
Until others be able to also check it out
…se v3 and the new alpha kustomze/v2-alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@everettraven: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlmogBaku, camilamacedo86, everettraven, NikhilSharmaWe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel we are good to move with this one :-) |
Motivation
Closes: #2547