Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨(go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha #2552

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

NikhilSharmaWe
Copy link
Member

@NikhilSharmaWe NikhilSharmaWe commented Mar 19, 2022

Motivation

  • Allow users to begin to use the new kustomze eaiser by just calling kubebuilder init --plugin=go/v4-alpha
  • Add initial version for go/v4-alpha so that in follow-ups we can also create a go base v4 alpha plugin and begin to address changes like remove the logic to allow create v2beta1 CRDs and webhook which was removed with k8s 1.22
  • Also, seems time for we in a follow up deprecate the go/v2 plugin which was created to ensure backward compatibility with the legacy layout of Kubebuilder < 3.0.0 and no longer can be updated

Closes: #2547

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 19, 2022
@NikhilSharmaWe

This comment was marked as resolved.

@NikhilSharmaWe NikhilSharmaWe force-pushed the newPlugin branch 3 times, most recently from cf14483 to d1f3058 Compare March 20, 2022 04:48
@camilamacedo86

This comment was marked as resolved.

@NikhilSharmaWe

This comment was marked as resolved.

@NikhilSharmaWe

This comment was marked as resolved.

@NikhilSharmaWe NikhilSharmaWe force-pushed the newPlugin branch 2 times, most recently from 2a06d1f to c9c52ef Compare March 20, 2022 05:39
@camilamacedo86

This comment was marked as resolved.

Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@NikhilSharmaWe NikhilSharmaWe changed the title Added pkg/plugins/golang/v4/ for creating new go/v4 plugin ✨ Add go/v4 alpha plugin Mar 20, 2022
@NikhilSharmaWe

This comment was marked as resolved.

@Ankit152

This comment was marked as resolved.

@NikhilSharmaWe

This comment was marked as resolved.

@camilamacedo86

This comment was marked as resolved.

@NikhilSharmaWe NikhilSharmaWe force-pushed the newPlugin branch 7 times, most recently from 6fb7b17 to 2ff0972 Compare May 19, 2022 16:22
@NikhilSharmaWe NikhilSharmaWe changed the title ✨ Initial base-code for go/v4 alpha plugin ✨(go/v4-alpha): add new golang plugin which uses the default golang base v3 and the new alpha kustomze/v2-alpha May 19, 2022
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🥇

IHMO we need to move forward here and add the go/v4-alpha to make it easier for users to begin to experiment kustomize v4 with and we begin to support Apple Silicon.

Also, it seems time to deprecate go/v2 since we no longer can update it (it was created only to ensure the backwards compatibility)

/hold

Until others be able to also check it out

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2022
cmd/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@everettraven: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 requested a review from AlmogBaku May 25, 2022 01:34
@AlmogBaku
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlmogBaku, camilamacedo86, everettraven, NikhilSharmaWe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@camilamacedo86
Copy link
Member

/hold cancel

we are good to move with this one :-)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit c199e69 into kubernetes-sigs:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create go/v4 plugin with alpha1 level to address changes which are breaking ones for go/v3
6 participants