Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove CLI interface and expose cli instead #2079

Merged
merged 1 commit into from
Mar 10, 2021
Merged

🌱 Remove CLI interface and expose cli instead #2079

merged 1 commit into from
Mar 10, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Mar 10, 2021

It also improves the documentation of all the exported pieces of this package.

Closes: #2078

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy March 10, 2021 08:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2021
@Adirio Adirio mentioned this pull request Mar 10, 2021
Closed
14 tasks
@Adirio
Remove CLI interface and expose cli instead
4e6c400 
Improve the documentation of all the exported pieces of this package.

Signed-off-by: Adrian Orive <[email protected]>
@Adirio Adirio force-pushed the cli-external-api branch from 7dc813a to 4e6c400 Compare March 10, 2021 09:30
camilamacedo86
camilamacedo86 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only a small change to improve the docs of the pkg.
Does not affect its consumers.

So, it shows fine we

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Adirio,camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit de84b80 into kubernetes-sigs:master Mar 10, 2021
@Adirio Adirio deleted the cli-external-api branch March 10, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing unexported type cli from documentation in pkg.go.dev
3 participants
@Adirio @k8s-ci-robot @camilamacedo86