-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add the liveness and readiness probe in the manager deployment #1795
Conversation
/cc @camilamacedo86 |
86675ad
to
316767f
Compare
/test pull-kubebuilder-e2e-k8s-1-17-0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked this one 🥇 . its motivations came from community requests made in SDK operator-framework/operator-sdk#4102. I pinged it in the slack as well for we get feedback from the community. Let's see.
Seems pretty low risk and a good addition to level up the base scaffolding. Before #1790 is done I'll need to make sure we don't change the lgtm! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, prafull01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think it is fine to get merged so; |
@prafull01 did you manually test this change? I don't think these endpoints are available by default. |
@estroz Hi Eric, I thought the following e2e scenario would cover the checking of controller-manager coming up: kubebuilder/test/e2e/v3/e2e_suite.go Line 168 in 7db6812
|
Description
Add the liveness and readiness probe for the manager deployment.
Motivation
Fixes: #1761