Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only) #1787

Merged
merged 1 commit into from
Nov 5, 2020
Merged

⚠️ upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only) #1787

merged 1 commit into from
Nov 5, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Nov 4, 2020 •
edited
Loading

Description

  • upgrade controller-tool dep from 0.3.0 to 0.4.0 (go/v3-alpha only)

NOTE: The controller-tool no generates CRD version to v1 by default (#468) and add admissionregisteration/v1 support for webhook (#469) which means that are breaking changes for v2+. Then, because of this, the fix can only be addressed to v3+ plugin.

Motivation
Closes: #1634

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 5, 2020
@djzager
Copy link

djzager commented Nov 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4d89cfe into kubernetes-sigs:master Nov 5, 2020
@camilamacedo86 camilamacedo86 deleted the upgrade-controller-gen branch November 5, 2020 21:14
@estroz
Copy link
Contributor

estroz commented Nov 10, 2020

This PR broke go/v3-alpha silently because testdata generation can only use one tool version per script invocation, i.e. all testdata is generated with controller-gen v0.3.0 right now. This blocks #1756, so we'll have to go ahead and merge its parent PR #1644 to fix go/v3-alpha.

This was referenced Nov 10, 2020
Merged
Merged
@camilamacedo86 camilamacedo86 mentioned this pull request Nov 11, 2020
Closed
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Adirio left review comments

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@djzager djzager

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camilamacedo86 @k8s-ci-robot @djzager @estroz @Adirio