Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Duplicate the check run even if we need to re-run the tests #20

Merged
merged 1 commit into from
Nov 20, 2020
Merged

🐛 Duplicate the check run even if we need to re-run the tests #20

merged 1 commit into from
Nov 20, 2020

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Nov 19, 2020

#17 wasn't fully solved by #18, see #17 (comment)

Fixes #17

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2020
@Adirio Adirio mentioned this pull request Nov 19, 2020
Closed
6 tasks
@Adirio Adirio changed the title 🐛 Duplicate the check run even if we need to re-run the tests WIP 🐛 Duplicate the check run even if we need to re-run the tests Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Nov 19, 2020 •
edited
Loading

Requires #23 to get merged first

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2020
@Adirio Adirio changed the title WIP 🐛 Duplicate the check run even if we need to re-run the tests 🐛 Duplicate the check run even if we need to re-run the tests Nov 19, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2020
@DirectXMan12
Copy link
Contributor

generally looks fine (although if we choose to re-target on synchronize we might just want to immediately move to sending the results to HEAD, instead of duplicating them at the end), but see my comment on #21 for why we should not include #21

@Adirio
Copy link
Contributor Author

Adirio commented Nov 19, 2020

generally looks fine (although if we choose to re-target on synchronize we might just want to immediately move to sending the results to HEAD, instead of duplicating them at the end)

In most cases, that check will already be done and we will just send the results to HEAD. It computes them back if it can't find the Check Run and thus has to create it. I chose to send them back to the before commit too in order to avoid a hanging unfinished check.

@Adirio Adirio mentioned this pull request Nov 20, 2020
Merged
@Adirio
Copy link
Contributor Author

Adirio commented Nov 20, 2020

The dependency on #21 has been replaced by a dependency on #23, which just provides the improved debug output.

@Adirio Adirio force-pushed the fix-rebinding-2 branch 2 times, most recently from 6fbaf21 to 959e85c Compare November 20, 2020 23:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 20, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Nov 20, 2020

#23 merged

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@DirectXMan12
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2020
DirectXMan12
DirectXMan12 approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, DirectXMan12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5a2a603 into kubernetes-sigs:master Nov 20, 2020
@Adirio Adirio deleted the fix-rebinding-2 branch November 20, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Updating a Check Run HeadSHA is not working
3 participants
@Adirio @DirectXMan12 @k8s-ci-robot