cleanup externalSchedulerEnable #382
Conversation
k8s-ci-robot
added
kind/cleanup
|
Hi @YamasouA. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
ok-to-test
There was a problem hiding this comment.
We have to modify https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/simulator/docs/integrate-your-scheduler.md
to remove the mention to the external-scheduler.
Also, we have to modify https://github.com/kubernetes-sigs/kube-scheduler-simulator/blob/master/simulator/docs/debuggable-scheduler.md too.
There was a problem hiding this comment.
We can just remove all the content in this page except !CAUTION.
There was a problem hiding this comment.
I update these files.
k8s-ci-robot
added
size/L
| code := cli.Run(command) | ||
| cancelFn() | ||
| os.Exit(code) | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Sorry, we need ↓ here:
- Rebuild the scheduler and restart.
make docker_build docker_up_local
simulator/docs/external-scheduler.md
Outdated
| > [!CAUTION] | ||
| To maintain compatibility, the externalSchedulerEnabled setting remains available, but the feature is disabled. |
There was a problem hiding this comment.
| To maintain compatibility, the externalSchedulerEnabled setting remains available, but the feature is disabled. | |
| We previously had a feature called the external scheduler, but we removed it in favor of [debuggable scheduler](../debuggable-scheduler.md). | |
| To maintain compatibility, the externalSchedulerEnabled setting remains for now though, will be removed in the near future. |
| To add your custom scheduler plugins, refer to the following resources: | ||
| - [debuggable-scheduler.md](./debuggable-scheduler.md#integrate-your-plugins-to-the-simulator) for basic integration steps. | ||
| - [custom-plugin.md](./custom-plugin.md) for more detailed guidance on configuring out-of-tree plugins. |
There was a problem hiding this comment.
Ah, actually, we can remove custom-plugin.md as well because users can just register their custom plugins via the debuggable scheduler.
So, here can be simplified like:
| To add your custom scheduler plugins, refer to the following resources: | |
| - [debuggable-scheduler.md](./debuggable-scheduler.md#integrate-your-plugins-to-the-simulator) for basic integration steps. | |
| - [custom-plugin.md](./custom-plugin.md) for more detailed guidance on configuring out-of-tree plugins. | |
| To add your custom scheduler plugins, see [debuggable-scheduler.md](./debuggable-scheduler.md#integrate-your-plugins-to-the-simulator). |
And, also please remove the page custom-plugin.md.
|
@sanposhiho |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanposhiho, YamasouA The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/area simulator
What this PR does / why we need it:
after #370, we no longer have any use case for externalSchedulerEnable.
Which issue(s) this PR fixes:
Fixes #381
Special notes for your reviewer:
/label tide/merge-method-squash