-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: kube-scheduler-simulator #1
add: kube-scheduler-simulator #1
Conversation
Welcome @sanposhiho! |
5b5ebf2
to
7ff2258
Compare
COPY . . | ||
RUN go build -v -o ./bin/simulator simulator.go | ||
|
||
FROM alpine:3.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for separating build and final image 👍
@@ -0,0 +1,68 @@ | |||
package di |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: what does this stand for? can we use a more descriptive name for this package?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adtac, sanposhiho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds all codes of simulator🎉
/cc @adtac