Fix race condition if store result map

* Add mutexes to every read/write access the store makes to the results map
kubernetes-sigs · Feb 11, 2022 · 0aeb8f2 · 0aeb8f2
1 parent 17382c9
commit 0aeb8f2
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/scheduler/plugin/resultstore/store.go b/scheduler/plugin/resultstore/store.go
@@ -87,6 +87,8 @@ func newData() *result {
 }
 
 func (s *Store) addSchedulingResultToPod(_, newObj interface{}) {
+	s.mu.Lock()
+	defer s.mu.Unlock()
 	ctx := context.Background()
 
 	pod, ok := newObj.(*v1.Pod)
@@ -233,5 +235,7 @@ func (s *Store) applyWeightOnScore(pluginName string, score int64) int64 {
 }
 
 func (s *Store) DeleteData(k key) {
+	s.mu.Lock()
+	defer s.mu.Unlock()
 	delete(s.results, k)
 }