Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Added --schedule-period #414

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Added --schedule-period #414

merged 1 commit into from
Oct 11, 2018

Conversation

k82cn
Copy link
Contributor

@k82cn k82cn commented Oct 11, 2018

Signed-off-by: Da K. Ma [email protected]

fixes: #412

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2018
@TravisBuddy
Copy link

Travis tests have failed

Hey @k82cn,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make verify
go build -o _output/bin/deepcopy-gen ./cmd/deepcopy-gen/
_output/bin/deepcopy-gen -i ./pkg/apis/scheduling/v1alpha1/ -O zz_generated.deepcopy
hack/verify-gofmt.sh
./cmd/kube-batch/app/options/options.go:63:5: expected boolean expression, found simple statement (missing parentheses around composite literal?)
make: *** [verify] Error 1
make
$ make
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/cmd/kube-batch/app/options
cmd/kube-batch/app/options/options.go:63:52: syntax error: _, err := time.ParseDuration(s.SchedulePeriod) used as value
make: *** [kube-batch] Error 2
make e2e
mkdir -p _output/bin
go build -o _output/bin/kube-batch ./cmd/kube-batch/
# github.com/kubernetes-sigs/kube-batch/cmd/kube-batch/app/options
cmd/kube-batch/app/options/options.go:63:52: syntax error: _, err := time.ParseDuration(s.SchedulePeriod) used as value
make: *** [kube-batch] Error 2
TravisBuddy Request Identifier: 0db5fc60-cd23-11e8-9005-69b5ac3c7904

Signed-off-by: Da K. Ma <[email protected]>
@k82cn
Copy link
Contributor Author

k82cn commented Oct 11, 2018

Updated test result here:

k82cn@wgl-ubuntu:~/go_ws/src/github.com/kubernetes-sigs/kube-batch$ grep "End scheduling" scheduler.log
I1011 16:52:31.771342    2249 scheduler.go:94] End scheduling ...
I1011 16:52:41.771765    2249 scheduler.go:94] End scheduling ...
I1011 16:52:51.772482    2249 scheduler.go:94] End scheduling ...
I1011 16:53:01.772853    2249 scheduler.go:94] End scheduling ...
I1011 16:53:11.773183    2249 scheduler.go:94] End scheduling ...
I1011 16:53:21.773515    2249 scheduler.go:94] End scheduling ...
I1011 16:53:31.773887    2249 scheduler.go:94] End scheduling ...
k82cn@wgl-ubuntu:~/go_ws/src/github.com/kubernetes-sigs/kube-batch$ ps -ef | grep kube-batch
k82cn     2249 19378  0 16:52 pts/8    00:00:00 _output/bin/kube-batch --kubeconfig /home/k82cn/.kube/config --enable-namespace-as-queue=true --logtostderr --v 4 --schedule-period=10s
k82cn     2697 19378  0 16:53 pts/8    00:00:00 grep kube-batch
k82cn@wgl-ubuntu:~/go_ws/src/github.com/kubernetes-sigs/kube-batch$

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4a2be8e into kubernetes-retired:master Oct 11, 2018
@k82cn k82cn deleted the kb_412 branch October 12, 2018 03:06
k8s-ci-robot added a commit that referenced this pull request Oct 15, 2018
…ase-0.2

Automated cherry pick of #414: Added --schedule-period
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to config log level and schedule control loop frequency in configure file.
3 participants