feat: make fmt.FPrintln instead of klog while printing error message

[developer-guy]

Signed-off-by: Batuhan Apaydın [email protected]

Fixes #717
Related issue: #717

cc: @Dentrax @erkanzileli

[k8s-ci-robot]

Welcome @developer-guy!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[corneliusweig]

As far as I understand, @developer-guy you agree that keeping klog here is the better choice, right? If not, please reopen.
/close

[k8s-ci-robot]

@corneliusweig: Closed this PR.

In response to this:

As far as I understand, @developer-guy you agree that keeping klog here is the better choice, right? If not, please reopen.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[developer-guy]

hi @corneliusweig, yes but just for printing the stack trace of the error like ahmetb said, fmt package would be ok for the other one.

[developer-guy]

@corneliusweig how can I re-open it?

[developer-guy]

/reopen

[k8s-ci-robot]

@developer-guy: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahmetb]

@corneliusweig I think for the user-visible message at -v=0 we can print without klog.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, developer-guy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[developer-guy]

sorry for the ping @corneliusweig but can you please tell me what can I do for completing this issue? Because I think it is ready to merge, isn't it?

[ahmetb]

/retest
for some reason the tests are failing

[developer-guy]

I'm not sure that it can help but tests are passing on my machine.

[ahmetb]

hack/run-integration-tests.sh is what's failing. Can be relevant since those tests check output.

[ahmetb]

I think the tests are failing because fmt.Print does not cause the process to exit with a non-zero status code :)

[developer-guy]

I think the tests are failing because fmt.Print does not cause the process to exit with a non-zero status code :)

thank you so much, I added a new line to make it exit with a non-zero status code.

[ahmetb]

/lgtm