Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: drop impi in favor of golangci-lint #698

Merged
merged 1 commit into from
Mar 12, 2021
Merged

hack: drop impi in favor of golangci-lint #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ linters:
enable:
- deadcode
- errcheck
- gci
- gocritic
- gofmt
- goimports
Expand Down
7 changes: 0 additions & 7 deletions hack/run-lint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,6 @@ fi
# configured by .golangci.yml
"$gopath/bin/golangci-lint" run

if ! [[ -x "${gopath}/bin/impi" ]]; then
echo >&2 'Installing impi'
go install github.com/pavius/impi/cmd/impi@c1cbdcb
fi

"$gopath/bin/impi" --local sigs.k8s.io/krew --scheme stdThirdPartyLocal ./...

# install shfmt that ensures consistent format in shell scripts
if ! [[ -x "${gopath}/bin/shfmt" ]]; then
echo >&2 'Installing shfmt'
Expand Down