-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to sample-cli-plugin in developer guide #466
Add link to sample-cli-plugin in developer guide #466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 56.52% 56.52%
=======================================
Files 19 19
Lines 927 927
=======================================
Hits 524 524
Misses 350 350
Partials 53 53 Continue to review full report at Codecov.
|
I think there are some changes we made to the sample-cli-plugin that aren’t merged still after such a long time. In that case we don’t need to link out until they’re merged. |
Sounds good, should I just close this? |
lets keep it open. |
Honestly I think it's ok sample-cli-plugin doesn't mention Krew in this case. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, chriskim06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Let me know if the wording of this should be changed at all.
Fixes #328