Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix url #447

Closed
wants to merge 4 commits into from
Closed

fix url #447

wants to merge 4 commits into from

Conversation

wyyxd2017
Copy link

fix a invalid url

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wyyxd2017
To complete the pull request process, please assign ahmetb
You can assign the PR to them by writing /assign @ahmetb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #447 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   56.54%   56.54%           
=======================================
  Files          19       19           
  Lines         925      925           
=======================================
  Hits          523      523           
  Misses        349      349           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c452b...14ccdb1. Read the comment docs.

@ahmetb
Copy link
Member

ahmetb commented Dec 30, 2019

This is incorrect.
/close
Please stop spamming the repo.

@ahmetb ahmetb closed this Dec 30, 2019
aimbot31 added a commit to aimbot31/krew that referenced this pull request Jan 13, 2020
@aimbot31
Ensure DownloadPath is always clean kubernetes-sigs#447
e9dc907 
Removed DownloadPath function.
Used ioutil.TempDir each time a tmpDir was needed.
Removed old tests on DownloadPath.
k8s-ci-robot pushed a commit that referenced this pull request Jan 27, 2020
@aimbot31 @k8s-ci-robot
Ensure DownloadPath is always clean #447 (#464)
da2c84b 
Removed DownloadPath function.
Used ioutil.TempDir each time a tmpDir was needed.
Removed old tests on DownloadPath.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyyxd2017 @k8s-ci-robot @codecov-io @ahmetb