-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: make test config explicit #320
lint: make test config explicit #320
Conversation
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
======================================
Coverage 57.3% 57.3%
======================================
Files 19 19
Lines 904 904
======================================
Hits 518 518
Misses 335 335
Partials 51 51 Continue to review full report at Codecov.
|
This setting is |
Yes, it's true by default but as in the linked comment, @ahmetb suggested to make it explicit unless hurts. |
Hmm.. if either of you feel strongly about making this explicit, I won't say no. But it feels a bit redundant. |
I think it's fine, if someday the default changes, we're shielded. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, ferhatelmas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
follow up on #318
addresses the request from this comment by explicitly including test files into lint