Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for krew upgrade #242

Merged
merged 5 commits into from
Jul 12, 2019
Merged

Add integration test for krew upgrade #242

merged 5 commits into from
Jul 12, 2019

Conversation

corneliusweig
Copy link
Contributor

Only happy path so far.

Close #233

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2019
@corneliusweig corneliusweig force-pushed the w/integration-upgrade branch from e02c949 to 3881ebb Compare July 3, 2019 07:27
@codecov-io
Copy link

codecov-io commented Jul 3, 2019 •
edited
Loading

Codecov Report

Merging #242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #242   +/-   ##
======================================
  Coverage    53.6%   53.6%           
======================================
  Files          16      16           
  Lines         735     735           
======================================
  Hits          394     394           
  Misses        289     289           
  Partials       52      52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d043a2e...856ae07. Read the comment docs.

@corneliusweig
Copy link
Contributor Author

Thanks for your suggestions, looks much better now. PTAL

This was referenced Jul 3, 2019
Closed
Merged
@ahmetb
Copy link
Member

ahmetb commented Jul 8, 2019

/approve
sorry for back-and-forth, will /lgtm once the comments are addressed.

@ahmetb
Copy link
Member

ahmetb commented Jul 12, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 268a72f into kubernetes-sigs:master Jul 12, 2019
@corneliusweig corneliusweig deleted the w/integration-upgrade branch July 12, 2019 20:56
@corneliusweig
Copy link
Contributor Author

sorry for back-and-forth

Don't be! Your reviews are very valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb left review comments

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@ahmetb ahmetb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Krew upgrade needs integration test
4 participants
@corneliusweig @codecov-io @ahmetb @k8s-ci-robot