-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to go modules (vgo) #235
Conversation
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 53.6% 53.78% +0.17%
==========================================
Files 16 14 -2
Lines 735 701 -34
==========================================
- Hits 394 377 -17
+ Misses 289 273 -16
+ Partials 52 51 -1
Continue to review full report at Codecov.
|
6ed7b96
to
7a3983e
Compare
This PR is too big, I can't add inline comments 😆
|
Signed-off-by: Ahmet Alp Balkan <[email protected]>
Anytime you fetch go modules, using GOPPROXY is much faster. See http://proxy.golang.org/. This speeds up the test suite. e.g.
Addressed merge conflicts.
Solved this by introducing a |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #234.
/assign @corneliusweig