Add spec.homepage field to the plugin manifest
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `spec.homepage` field of the plugin manifest defines the url of the
plugin project homepage. The field value should be a valid url.
In addition, if the `spec.homepage` field is defined in plugin manifest,
`kubectl krew info` command displays that field value as HOMEPAGE as follows:
$ kubectl krew info krew
NAME: krew
URI: https://storage.googleapis.com/krew/v0.2.1/krew.tar.gz
SHA256: dc2f2e1ec8a0acb6f3e23580d4a8b38c44823e948c40342e13ff6e8e12edb15a
VERSION: v0.2.1
HOMEPAGE: https://github.com/GoogleContainerTools/krew
...
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage 50.91% 50.91%
=======================================
Files 13 13
Lines 711 711
=======================================
Hits 362 362
Misses 297 297
Partials 52 52Continue to review full report at Codecov.
|
ahmetb
approved these changes
Mar 7, 2019
By this change, the output fields of `krew info` command are reordered as follows: ``` $ out/bin/krew-darwin_amd64 info krew NAME: krew URI: https://storage.googleapis.com/krew/v0.2.1/krew.tar.gz SHA256: dc2f2e1ec8a0acb6f3e23580d4a8b38c44823e948c40342e13ff6e8e12edb15a VERSION: v0.2.1 HOMEPAGE: https://github.com/GoogleContainerTools/krew CAVEATS: \ ... ```
ahmetb
reviewed
Mar 8, 2019
ahmetb
approved these changes
Mar 8, 2019
|
Should I squash this PR? |
ahmetb
approved these changes
Mar 8, 2019
|
Also home page is part of documentation technically. It's not good to fail parsing the index during an upgrade because some homepage URL was invalid. I think this is better. |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
spec.homepagefield to the plugin manifest./close #157
The
spec.homepagefield of the plugin manifest defines the url of theplugin project homepage. The field value should be a valid url.
In addition, if the
spec.homepagefield is defined in plugin manifest,kubectl krew infocommand displays that field value as HOMEPAGE as follows: