Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use small shell-based plugin for integration tests instead of konfig #410

Closed
corneliusweig opened this issue Nov 30, 2019 · 4 comments · Fixed by #465
Closed

Use small shell-based plugin for integration tests instead of konfig #410

corneliusweig opened this issue Nov 30, 2019 · 4 comments · Fixed by #465
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@corneliusweig
Copy link
Contributor

The integration tests in krew need to install a real plugin from the krew index. This needs to be small, so that the tests do not need to download large blobs for each run.

Currently, krew uses konfig for that. However, konfig creates a dedicated dist archive for distribution and does not use the repo tarball which is created automatically for github releases. This is ok, but github keeps track of download counts for release assets. As we run our tests often, this distorts the download numbers of konfig quite a bit. It would be better to switch to a small plugin which is distributed purely as repo tarball, for example ctx.

@corneliusweig
Copy link
Contributor Author

/good-first-issue
/help

@k8s-ci-robot
Copy link
Contributor

@corneliusweig:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 22, 2019
@chriskim06
Copy link
Member

I'd like to work on this!

/assign

@corneliusweig
Copy link
Contributor Author

Great! If you have questions, you can also reach out on slack or post here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants