Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rename dirs/files to make integration tests clear #229

Closed
ahmetb opened this issue Jun 27, 2019 · 3 comments · Fixed by #236 or #240
Closed

test: rename dirs/files to make integration tests clear #229

ahmetb opened this issue Jun 27, 2019 · 3 comments · Fixed by #236 or #240
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@ahmetb
Copy link
Member

ahmetb commented Jun 27, 2019

/kind cleanup

Right now we have paths like:

  • test/
    • ./krew.go ← unclear what it contains
    • ./krew_test.go ← unclear what it contains

which don't indicate that they're integration tests. I'd prefer we have something like this where we have a clear separation:

  • test/
    • testutil.go
    • integration_tests/
      • install_test.go
      • info_test.go
      • uninstall_test.go
      • version_test.go

so that we can more clearly do:

go test ./test/integration_tests/...

we can also directly call the root folder ./integration_tests and put all the files there.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 27, 2019
@corneliusweig
Copy link
Contributor

👍 from me. I'd prefer if the root test folder be called integration_test, so it is clear to everybody what's in there. And I would prefer a nested structure, though flat is also fine.

@corneliusweig
Copy link
Contributor

/reopen
Because we still need to split the test file into smaller bits.

@k8s-ci-robot
Copy link
Contributor

@corneliusweig: Reopened this issue.

In response to this:

/reopen
Because we still need to split the test file into smaller bits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
3 participants