Skip to content

Commit

Permalink
Fix handling when no matching platform is found (#345)
Browse files Browse the repository at this point in the history
`err` is nil here, so errors.Wrapf(...) is nil too, so that the
calling code assumes that no error happened.
  • Loading branch information
corneliusweig authored and k8s-ci-robot committed Sep 24, 2019
1 parent 641920a commit e88f854
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/installation/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func Install(p environment.Paths, plugin index.Plugin, opts InstallOpts) error {
return errors.Wrap(err, "failed trying to find a matching platform in plugin spec")
}
if !ok {
return errors.Wrapf(err, "plugin %q does not offer installation for this platform", plugin.Name)
return errors.Errorf("plugin %q does not offer installation for this platform", plugin.Name)
}

// The actual install should be the last action so that a failure during receipt
Expand Down

0 comments on commit e88f854

Please sign in to comment.