Skip to content

Commit

Permalink
Remove outdated TODO comment (#777)
Browse files Browse the repository at this point in the history
  • Loading branch information
JohnTitor authored May 11, 2022
1 parent b18ef16 commit d3c7635
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions internal/download/downloader.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,6 @@ var defaultExtractors = map[string]extractor{
}

func extractArchive(dst string, at io.ReaderAt, size int64) error {
// TODO(ahmetb) This package is not architected well, this method should not
// be receiving this many args. Primary problem is at GetInsecure and
// GetWithSha256 methods that embed extraction in them, which is orthogonal.

t, err := detectMIMEType(at)
if err != nil {
return errors.Wrap(err, "failed to determine content type")
Expand All @@ -210,7 +206,6 @@ func extractArchive(dst string, at io.ReaderAt, size int64) error {
return errors.Errorf("mime type %q for archive file is not a supported archive format", t)
}
return errors.Wrap(exf(dst, at, size), "failed to extract file")

}

// Downloader is responsible for fetching, verifying and extracting a binary.
Expand Down

0 comments on commit d3c7635

Please sign in to comment.