hack: update verify-code-patterns.sh (#221)

This fixes an issue where sometimes bash returns 1 instead of 123 in the exitcode of the pipe. This simplifies the find|xargs|grep with just grep. Signed-off-by: Ahmet Alp Balkan <[email protected]>
kubernetes-sigs · Jun 27, 2019 · 4e47fbc · 4e47fbc
1 parent bca4cde
commit 4e47fbc
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/hack/verify-code-patterns.sh b/hack/verify-code-patterns.sh
@@ -16,7 +16,8 @@
 
 set -euo pipefail
 
-out="$( find . -name '*_test.go' -not -path './vendor/*' -print0 | xargs -0 grep -En 'ioutil\.TempDir' || [[ $? == 123 ]] )"
+# Disallow usage of ioutil.TempDir in tests in favor of testutil.
+out="$(grep --include '*_test.go' --exclude-dir 'vendor/' -EIrn 'ioutil.\TempDir' || true)"
 if [[ -n "$out" ]]; then
   echo >&2 "You used ioutil.TempDir in tests, use 'testutil.NewTempDir()' instead:"
   echo >&2 "$out"