Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version v1.2.0 of auth-proxy #1789

Conversation

int128
Copy link
Contributor

@int128 int128 commented Nov 28, 2021

Follow up #1787. I fixed the binary name of windows/amd64.

@ahmetb
Copy link
Member

ahmetb commented Nov 28, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/auth-proxy.yaml is not a straightforward version bump: change on line 8 does not seem like a version bump: [- bin: kauthproxy]

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: int128
To complete the pull request process, please assign corneliusweig after the PR has been reviewed.
You can assign the PR to them by writing /assign @corneliusweig in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2021
@int128 int128 force-pushed the int128-auth-proxy-kauthproxy-v1.2.0 branch from 40aa780 to 52830da Compare November 28, 2021 03:04
@ahmetb
Copy link
Member

ahmetb commented Nov 28, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/auth-proxy.yaml is not a straightforward version bump: change on line 8 does not seem like a version bump: [- bin: kauthproxy]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 28, 2021
@int128 int128 marked this pull request as draft November 28, 2021 03:07
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2021
@int128 int128 closed this Nov 28, 2021
@int128 int128 deleted the int128-auth-proxy-kauthproxy-v1.2.0 branch November 28, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants