Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version v0.2.0 of operator #1042

Merged
merged 1 commit into from
Feb 17, 2021
Merged

new version v0.2.0 of operator #1042

merged 1 commit into from
Feb 17, 2021

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Feb 17, 2021

Normal version bump, but this also adds platform support for darwin/arm64 for the operator plugin.

@ahmetb
Copy link
Member

ahmetb commented Feb 17, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/operator.yaml is not a straightforward version bump: change on line 7 does not seem like a version bump: [+ bin: kubectl-operator]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 17, 2021
@joelanford
Copy link
Member Author

Seems like I need to wait for a new krew release that contains kubernetes-sigs/krew#693 and then update the version of validate-krew-manifest used by the PR verifier in this repo, similar to #1041.

@ahmetb
Copy link
Member

ahmetb commented Feb 17, 2021

fixing this in #1043, but I'll manually merge this.
/lgtm
/approve

@ahmetb ahmetb merged commit c63c747 into kubernetes-sigs:master Feb 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 17, 2021
@joelanford
Copy link
Member Author

Thanks for the fast turnaround on these PRs! In case you didn't have an M1 Mac laying around anywhere, I can confirm that krew v0.4.1 and this plugin installation worked no problem on mine.

@joelanford joelanford deleted the update-operator-v0.2.0 branch January 25, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants