Require nft v1.0.1 or later

[danwinship]

Part of fixing kubernetes/kubernetes#122743

/assign @uablrek
(though it's not autocompleting so I guess you're probably not a member of the kubernetes-sigs org so it won't actually assign you... and maybe you won't be able to /lgtm either?)

[k8s-ci-robot]

@danwinship: GitHub didn't allow me to assign the following users: uablrek.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Part of fixing kubernetes/kubernetes#122743

/assign @uablrek
(though it's not autocompleting so I guess you're probably not a member of the kubernetes-sigs org so it won't actually assign you... and maybe you won't be able to /lgtm either?)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[uablrek]

Beside the comment above this lgtm.

I tested to build kube-proxy with this PR just to see what happens. Log (--v=7):

E0129 08:57:36.705131     376 server.go:558] "Error running ProxyServer" err="unable to create proxier: unable to create ipv4 proxier: nft version must be v1.0.1 or later (got nftables v1.0.0 (Fearless Fosdick #2))"
E0129 08:57:36.705212     376 run.go:74] "command failed" err="unable to create proxier: unable to create ipv4 proxier: nft version must be v1.0.1 or later (got nftables v1.0.0 (Fearless Fosdick #2))"

K8s "make" doesn't work with go workspaces, so this is how I built:

cd $GOPATH/src/k8s.io/kubernetes
go work init .
go work use $GOPATH/src/github.com/kubernetes-sigs/knftables
go build -o _output/bin/kube-proxy ./cmd/kube-proxy
strip _output/bin/kube-proxy

Is there a better way?

[uablrek]

Can I become a member of the kubernetes-sigs org? If so, how? (I didn't find any instruction with google, and no "community" repo)

[aroradaman]

Can I become a member of the Kubernetes-sigs org? If so, how? (I didn't find any instruction with google, and no "community" repo)

You can directly raise a PR in k/org as you are already a member of the Kubernetes org.

[danwinship]

the comment for this function above doesn't make sense:

clarified

Is there a better way?

For quick testing I would have just copied the updated code into vendor/sigs.k8s.io/knftables in k/k. For slightly-less-quick testing I would have updated go.mod to refer to the updated git SHA and then run ./hack/update-vendor.sh

(Tim is working on workspace support for k/k: https://github.com/kubernetes/kubernetes/pull/122624/commits)

[uablrek]

You can directly raise a PR in k/org as you are already a member of the Kubernetes org.

@danwinship @aroradaman May I name you as sponsors?

[aroradaman]

You can directly raise a PR in k/org as you are already a member of the Kubernetes org.

@danwinship @aroradaman May I name you as sponsors?

You don't need sponsors for this / or create an issue, you can directly raise a PR with the change in config/kubernetes-sigs/org.yaml

see - kubernetes/org#4022 (comment)

[uablrek]

/assign

I am a member now 😄

[uablrek]

/lgtm