support disabling default cni #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
BenTheElder
commented
May 15, 2019
| // this step might be skipped, but is next after init | ||
| if !cfg.Networking.DisableDefaultCNI { | ||
| actionsToRun = append(actionsToRun, | ||
| installcni.NewAction(), // install CNI |
There was a problem hiding this comment.
we could alternatively guard against this inside the action, I'm not sure this detail is important currently though as both are wholly internal to kind and should have roughly the same effect, but that might be a better refactor in the future.
Closed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #205 (though perhaps we need to follow up with docs 🙃 )
With this feature, users can skip the CNI installation and instead install their own CNI using the usual mechanisms (
kubectl apply -f my-cni-manifest.yaml ...). This is an advanced use case and not strongly supported, but should be available. It seems a number of projects have found installing / testing their own CNI useful, and this makes it easier to do without poking at kind's internals 😉