add staticcheck to verify #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| # enable modules and the proxy cache | ||
| export GO111MODULE="on" | ||
| GOPROXY="${GOPROXY:-https://proxy.golang.org}" | ||
| export GOPROXY |
There was a problem hiding this comment.
can use export GOPROXY="${GOPROXY:-https://proxy.golang.org}" directly
There was a problem hiding this comment.
🤷♂️ probably. but for now I'd prefer to be consistent with the other scripts
|
corrected the copyright and shebang |
neolit123
reviewed
May 15, 2019
k8s-ci-robot
added
the
lgtm
tao12345666333
approved these changes
May 15, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and fix something it found in the fuzzer tests! (second commit)
part of #528