Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add systemd restart override #483

Merged
merged 2 commits into from
May 4, 2019
Merged

add systemd restart override #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6f0fe
add restart override
BenTheElder May 4, 2019
07d8e0a
bump base to v20190504-2f6f0fe
BenTheElder May 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions images/base/10-restart.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# ensure the service is restarted
[Service]
Restart=always
RestartSec=1

# disable rate limiting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why disabling the rate limiting?
I experienced problems because a service is restarting continuously but the check wasn´t able to detect it down , can this happen to us?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It starts in under a second, the default rate limit of 5 in 10s doesn't seem useful in the context of kind, if we can determine a better one for kind we should do that.

We have no checks for this, instead we're observing if the workloads are up.

kubelet and containerd are our only services.

[Unit]
StartLimitIntervalSec=0
3 changes: 3 additions & 0 deletions images/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ RUN clean-install \
&& chmod +x /usr/local/bin/ctr \
&& echo "done installing packages"

# add restart override to containerd
COPY 10-restart.conf /etc/systemd/system/containerd.service.d/

# debug containerd version and create default config
# additionally, disable some plugins we don't use / support
RUN containerd --version \
Expand Down
Loading