Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ppc64le to release script #482

Merged
merged 1 commit into from
May 5, 2019
Merged

Add ppc64le to release script #482

merged 1 commit into from
May 5, 2019

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented May 4, 2019

@k8s-ci-robot k8s-ci-robot requested review from BenTheElder and dims May 4, 2019 08:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2019
@mkumatag
Copy link
Member Author

mkumatag commented May 4, 2019

/assign @munnerz

@BenTheElder
Copy link
Member

Thanks, do we know that it works on PPC now? 😁

BenTheElder
BenTheElder approved these changes May 5, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
hoping for confirmation that it is in fact working, but we can always release with a caveat in the release notes 😅

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit be15526 into kubernetes-sigs:master May 5, 2019
@mkumatag
Copy link
Member Author

mkumatag commented May 6, 2019

hoping for confirmation that it is in fact working, but we can always release with a caveat in the release notes 😅

good question! I see few issues, will submit the PRs once I'm able to debug.

@mkumatag mkumatag mentioned this pull request May 6, 2019
Closed
6 tasks
stg-0 pushed a commit to stg-0/kind that referenced this pull request Mar 4, 2024
@iamjanr
Fix failures (kubernetes-sigs#482)
83d0d72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@dims dims Awaiting requested review from dims

Assignees

@munnerz munnerz

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkumatag @BenTheElder @k8s-ci-robot @munnerz