Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: enable hostpath provisioner #397

Merged
merged 1 commit into from
Mar 25, 2019
Merged

feature: enable hostpath provisioner #397

merged 1 commit into from
Mar 25, 2019

Conversation

joejulian
Copy link
Contributor

@joejulian joejulian commented Mar 22, 2019 •
edited by BenTheElder
Loading

kind creates a default host-path StorageClass but cannot create
PersistentVolumes because the enable-hostpath-provisioner flag is not
set on kube-controller-manager.

This configures kubeadm to enable that feature.

xref #118

@joejulian
feature: enable hostpath provisioner
fdfc7ff 
kind creates a default host-path StorageClass but cannot create
PersistentVolumes because the `enable-hostpath-provisioner` flag is not
set on kube-controller-manager.

This configures kubeadm to enable that feature.

Fixes kubernetes-sigs#118
@k8s-ci-robot
Copy link
Contributor

Welcome @joejulian!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2019
@k8s-ci-robot k8s-ci-robot requested review from amwat and munnerz March 22, 2019 18:44
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @joejulian. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2019
@joejulian
Copy link
Contributor Author

/assign @BenTheElder

@BenTheElder
Copy link
Member

/ok-to-test
thanks!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2019
@aojea aojea mentioned this pull request Mar 25, 2019
Closed
BenTheElder
BenTheElder approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, joejulian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2019
@BenTheElder
Copy link
Member

we probably should note somewhere that this is not going to work well with multinode. https://github.com/kubernetes/kubernetes/blob/c48ed1c5aca6e06b6a3d70d5f189216df3150379/cmd/kube-controller-manager/app/options/persistentvolumebindercontroller.go#L40, we probably still want a multi-node aware option for #118

@BenTheElder BenTheElder mentioned this pull request Mar 25, 2019
Closed
@BenTheElder
Copy link
Member

BenTheElder commented Mar 25, 2019 •
edited
Loading

/retest
build (download) flake

@joejulian
Copy link
Contributor Author

Right. The intent of this PR is to fix the existing implementation. This feature should probably be redone to use local type.

@BenTheElder
Copy link
Member

(and thanks for fixing it! 😄)

@k8s-ci-robot k8s-ci-robot merged commit 6c35d5e into kubernetes-sigs:master Mar 25, 2019
@joejulian joejulian deleted the add_hostpath_flag branch March 25, 2019 18:54
@BenTheElder BenTheElder mentioned this pull request Mar 28, 2019
Merged
stg-0 pushed a commit to stg-0/kind that referenced this pull request Dec 15, 2023
@iamjanr
Update doc with AWSServiceRoleForAmazonEKS role information (kubernet…
5ad8b00 
…es-sigs#397)
@neolit123 neolit123 mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@amwat amwat Awaiting requested review from amwat

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joejulian @k8s-ci-robot @BenTheElder