Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: add examples for v1alpha3 #384

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Mar 14, 2019

  • add minimal multi CP example
  • update the example YAML to v1alpha3
  • add API redirect

fixes #266

/kind documentation
/priority important-longterm

- add minimal multi CP example
- update the example YAML to v1alpha3
- add API redirect
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 14, 2019
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @neolit123 Thanks. 👍

I am using this example to create a cluster for verification.

EDIT:

everything is ok. 😆

$ docker ps -f label=io.k8s.sigs.kind.cluster=moelove --format 'table {{ .Names }}\t{{ .Status}}\t{{ .Image }}'
NAMES                            STATUS              IMAGE
moelove-external-load-balancer   Up 16 minutes       kindest/node:v1.13.3
moelove-control-plane            Up 16 minutes       kindest/node:v1.13.3
moelove-control-plane2           Up 16 minutes       kindest/node:v1.13.3
moelove-worker                   Up 16 minutes       kindest/node:v1.13.3
moelove-worker3                  Up 16 minutes       kindest/node:v1.13.3
moelove-control-plane3           Up 16 minutes       kindest/node:v1.13.3
moelove-worker2                  Up 16 minutes       kindest/node:v1.13.3

Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member

let's add our networking field in a follow-up

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit d4ff13e into kubernetes-sigs:master Mar 20, 2019
stg-0 added a commit to stg-0/kind that referenced this pull request Dec 14, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document how to use HA
5 participants