[WIP] Kind cloud-provider to manage loadbalancers #3103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement an external cloud provider for kind clusters. The cloud-provider received the name of the kind cluster, and automatically pulls the kubeconfig from the control plane. It implements the InstancesV2() and LoadBalancer() internfaces of k8s.io/cloud-provider. The LoadBalancer creates haproxy containers and configures them accordenly. This version only supports linux, but next version will support platforms that run into VMs (Mac, windows, ...) by exposing the loadbalancer containers via port-forwards. The InstancesV2() option requires to configure kubelet with the flag --cloud-provider external and remove the --node-ip flags, something that has to be done manually on kind.
It adds an option on the kind configuration, under the networking section, to enable the kind cloud controller manager. The section is under networking because the only functionality that can be used out of the box are the loadbalancers.
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
this will be better standalone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These feature try to solve two important issues:
Current e2e test for cloud-providers has plenty of customization, the lack of agnostic e2e tests on this area makes that the migration to out-of-tree cloud-providers can drift providing a very bad user experience and non-portable configurations.
Kind has demonstrated several times its versatility and capacity to develop agnostic e2e tests.
This is a long standing demand, users need to come with complex and convoluted solutions to expose Services, having an out-of-the-box and realistic capacity to expose Service will improve the UX.
How to use it
Demo
Sig-Network meeting on 16 Febr 2023 https://www.youtube.com/playlist?list=PL69nYSiGNLP2E8vmnqo5MwPOY25sDWIxb
Prototype
https://github.com/aojea/cloud-provider-kind/
Fixes: #3086
Fixes: #702
Related: kubernetes/kubernetes#73794