-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated QEMU image and added cross build support for s390x kind binary and associated images #2494
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @guirish. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: guirish The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please sign the CLA @guirish |
"I signed it" |
@@ -46,11 +46,12 @@ export GOOS=darwin GOARCH=arm64 | |||
export GOOS=linux GOARCH=amd64 | |||
export GOOS=linux GOARCH=arm64 | |||
export GOOS=linux GOARCH=ppc64le | |||
export GOOS=linux GOARCH=s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO (unrelated to this PR): add ppc64le back to images/Makefile.common.in or drop it here.
/ok-to-test |
The commit in this PR is not associated with your GitHub account (I think maybe email not included?), the CNCF CLA bot requires that:
Right now it's failing on 2). |
|
…y and associated images
c050ed2
to
86bc9e4
Compare
The file https://github.com/kubernetes-sigs/kind/blob/main/images/base/Dockerfile has to be updated to download the corresponding dependencies |
it only needs diff --git a/images/base/update-shasums.sh b/images/base/update-shasums.sh
index 8876e833..86c30ac8 100755
--- a/images/base/update-shasums.sh
+++ b/images/base/update-shasums.sh
@@ -39,6 +39,7 @@ ARCHITECTURES=(
"amd64"
"arm64"
"ppc64le"
+ "s390x"
)
echo |
I'll take it from here, and add it for the image base bump |
/hold |
rebased merged in #2465 thanks! |
Hi, which kind version and on what date will have s390x support ? @BenTheElder Thanks :) |
In the next release there will be very limited support in which the non-configurable development images are s390x, and the binary is s390x. There is no intention to build node images for s390x at this time, nor CI / testing. |
Also noting: I've had builds hang on s390x a few times now :/ |
Updated QEMU image to
tonistiigi/binfmt:qemu-v6.1.0
and added cross build support for s390x kind binary and associated images.