-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade pause image to 3.6 #2451
upgrade pause image to 3.6 #2451
Conversation
Signed-off-by: kerthcet <[email protected]>
Welcome @kerthcet! |
Hi @kerthcet. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kerthcet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maybe building the base image with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade pause image to 3.6, an notable change since 3.5 is the Windows Server 2022 support, mentioned on issue
kind does not run directly on Windows nodes, but keeping up to date with the latest pause makes sense to me.
LGTM
/ok-to-test
got it, thanks for explaining. |
Usually there is a rollout for this to all the projects and not an immediate jump forward. cc @dims |
refer to kubernetes/kubernetes#104890 as an overview. |
see https://kubernetes.slack.com/archives/C0BP8PW9G/p1631032292078800 for a discussion of this in sig-node. I'd prefer to see this written down somewhere and a procedure enacted before we continue doing this ad-hoc. |
yeah, of course, this may be help. https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/updating-pause-images.md |
We could wait for the higher level PRs merged, then take this one into consider. I will track the whole process anyway. |
I think it's time to push this forward. |
kindly ping @BenTheElder |
is this because of kubernetes/kubernetes@18936d4 ? what is the trigger to update it in kind, I can't get the details from the slack and sig-node links? |
it's not a mandatory requirement to upgrade pause image to tag 3.6 but a procedure to keep the pause image with the latest stable version, which can refer to docs, also a tracing link |
sorry , I wasn't asking for that, it was more about "what did changed that we can merge now?" 😅 |
well, since related projects have already upgraded to the tag 3.6,no special reason but a procedure🚀 |
Ah, so the others already have upgraded |
yep |
to pick this up we'll need that base image bump @aojea |
aggregated to the PR bumping the base image #2465 |
rebased merged in #2465 |
Signed-off-by: kerthcet [email protected]
Upgrade pause image to 3.6, an notable change since 3.5 is the Windows Server 2022 support, mentioned on issue: kubernetes/kubernetes#104711