Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pause image to 3.6 #2451

Conversation

kerthcet
Copy link
Contributor

@kerthcet kerthcet commented Sep 6, 2021

Signed-off-by: kerthcet [email protected]
Upgrade pause image to 3.6, an notable change since 3.5 is the Windows Server 2022 support, mentioned on issue: kubernetes/kubernetes#104711

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @kerthcet!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @kerthcet. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kerthcet
To complete the pull request process, please assign munnerz after the PR has been reviewed.
You can assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2021
@kerthcet
Copy link
Contributor Author

kerthcet commented Sep 6, 2021

maybe building the base image with make -C images/base push is required, right? @BenTheElder

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade pause image to 3.6, an notable change since 3.5 is the Windows Server 2022 support, mentioned on issue

kind does not run directly on Windows nodes, but keeping up to date with the latest pause makes sense to me.

LGTM
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2021
@kerthcet
Copy link
Contributor Author

kerthcet commented Sep 7, 2021

Upgrade pause image to 3.6, an notable change since 3.5 is the Windows Server 2022 support, mentioned on issue

kind does not run directly on Windows nodes, but keeping up to date with the latest pause makes sense to me.

LGTM
/ok-to-test

got it, thanks for explaining.

@BenTheElder
Copy link
Member

Usually there is a rollout for this to all the projects and not an immediate jump forward. cc @dims

@kerthcet
Copy link
Contributor Author

Usually there is a rollout for this to all the projects and not an immediate jump forward. cc @dims

refer to kubernetes/kubernetes#104890 as an overview.

@BenTheElder
Copy link
Member

see https://kubernetes.slack.com/archives/C0BP8PW9G/p1631032292078800 for a discussion of this in sig-node. I'd prefer to see this written down somewhere and a procedure enacted before we continue doing this ad-hoc.

@kerthcet
Copy link
Contributor Author

see https://kubernetes.slack.com/archives/C0BP8PW9G/p1631032292078800 for a discussion of this in sig-node. I'd prefer to see this written down somewhere and a procedure enacted before we continue doing this ad-hoc.

yeah, of course, this may be help. https://github.com/kubernetes/community/blob/master/contributors/devel/sig-node/updating-pause-images.md

@kerthcet
Copy link
Contributor Author

We could wait for the higher level PRs merged, then take this one into consider. I will track the whole process anyway.

@kerthcet
Copy link
Contributor Author

I think it's time to push this forward.

@kerthcet
Copy link
Contributor Author

kerthcet commented Oct 8, 2021

I think it's time to push this forward.

kindly ping @BenTheElder

@aojea
Copy link
Contributor

aojea commented Oct 8, 2021

I think it's time to push this forward.

kindly ping @BenTheElder

is this because of kubernetes/kubernetes@18936d4 ?

what is the trigger to update it in kind, I can't get the details from the slack and sig-node links?

@kerthcet
Copy link
Contributor Author

kerthcet commented Oct 8, 2021

I think it's time to push this forward.

kindly ping @BenTheElder

is this because of kubernetes/kubernetes@18936d4 ?

what is the trigger to update it in kind, I can't get the details from the slack and sig-node links?

it's not a mandatory requirement to upgrade pause image to tag 3.6 but a procedure to keep the pause image with the latest stable version, which can refer to docs, also a tracing link

@aojea
Copy link
Contributor

aojea commented Oct 8, 2021

sorry , I wasn't asking for that, it was more about "what did changed that we can merge now?" 😅

@kerthcet
Copy link
Contributor Author

kerthcet commented Oct 9, 2021

sorry , I wasn't asking for that, it was more about "what did changed that we can merge now?" 😅

well, since related projects have already upgraded to the tag 3.6,no special reason but a procedure🚀

@aojea
Copy link
Contributor

aojea commented Oct 9, 2021

Ah, so the others already have upgraded

@kerthcet
Copy link
Contributor Author

Ah, so the others already have upgraded

yep

@BenTheElder
Copy link
Member

to pick this up we'll need that base image bump @aojea
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2021
@aojea aojea mentioned this pull request Oct 12, 2021
@aojea
Copy link
Contributor

aojea commented Oct 12, 2021

aggregated to the PR bumping the base image #2465

@BenTheElder
Copy link
Member

rebased merged in #2465
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants