bump kindnetd deps and remove pkg/errors dep #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aojea
commented
Jun 29, 2021
aojea
commented
- remove pkg/errors dependency
- bump golang to 1.16
- bump k8s deps to 1.21.2
- bump base image to debian-iptables:buster-v1.6.5
- bump klog ro 2.9.0
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
/assign @BenTheElder |
k8s-ci-robot
added
the
size/L
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
BenTheElder
reviewed
Jun 29, 2021
| k8s.io/apimachinery v0.20.5 | ||
| k8s.io/client-go v0.20.5 | ||
| k8s.io/klog/v2 v2.4.0 | ||
| k8s.io/api v0.21.2 |
There was a problem hiding this comment.
time to bump go in the image? done already, skimmed too fast
There was a problem hiding this comment.
and probably the go statement in the module?
BenTheElder
reviewed
Jun 29, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.